[PR #7] [MERGED] Disable Linux in-app global hotkeys and switch to desktop custom-shortcut command #7

New Issue

2026-08-08T18:06:18Z

jahruz67 commented

2026-08-08 18:06:18 +00:00

📋 Pull Request Information

Original PR: https://github.com/jahruz67/wisp-open/pull/7
Author: @jahruz67
Created: 7/15/2026
Status: ✅ Merged
Merged: 7/15/2026
Merged by: @jahruz67

Base: main ← Head: codex/detect-custom-shortcut-in-app

📝 Commits (1)

1e9862f Remove settings preview page

📊 Changes

13 files changed (+73 additions, -694 deletions)

View changed files

📝 README.md (+2 -6)
📝 app.go (+36 -76)
📝 frontend/index.html (+13 -5)
📝 frontend/src/main.js (+5 -1)
📝 go.mod (+0 -1)
📝 go.sum (+0 -2)
📝 internal/xhotkey/hotkey_linux.go (+3 -4)
📝 internal/xhotkey/hotkey_linux_platform.go (+1 -17)
➖ internal/xhotkey/hotkey_linux_portal.go (+0 -549)
📝 internal/xhotkey/hotkey_linux_test.go (+8 -28)
📝 internal/xhotkey/hotkey_linux_types.go (+1 -1)
📝 internal/xhotkey/hotkey_nocgo_test.go (+1 -1)
📝 scripts/build-linux.sh (+3 -3)

📄 Description

Motivation

Linux global-hotkey/portal code was fragile and introduced a D-Bus dependency and platform-specific complexity, so the app should rely on the user's desktop custom-shortcut mechanism instead.

Description

Stop registering an in-app global hotkey on Linux by making the Linux hotkey Register return an explanatory error and simplifying Unregister, and remove the portal backend implementation and godbus/dbus dependency from go.mod.
Prevent the app from starting the built-in hotkey listener on Linux and change SaveSettings to ignore in-app shortcut recording on Linux while preserving behavior on other OSes (app.go changes).
Update the UI and frontend to hide the shortcut recorder on Linux and expose a copyable Linux System Shortcut command shown in Settings, and update README.md and scripts/build-linux.sh messaging to document the new workflow.
Adjust and add tests to assert the Linux hotkey registration is disabled (internal/xhotkey/hotkey_linux_test.go) and update related test comments.

Testing

Ran the updated Linux hotkey unit test TestHotkeyLinuxUsesDesktopShortcutFallback in internal/xhotkey, which passed and confirmed Register returns the expected error.
Ran go test ./... across the repository and the test suite completed successfully.

Codex Task

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jahruz67/wisp-open/pull/7 **Author:** [@jahruz67](https://github.com/jahruz67) **Created:** 7/15/2026 **Status:** ✅ Merged **Merged:** 7/15/2026 **Merged by:** [@jahruz67](https://github.com/jahruz67) **Base:** `main` ← **Head:** `codex/detect-custom-shortcut-in-app` --- ### 📝 Commits (1) - [`1e9862f`](https://github.com/jahruz67/wisp-open/commit/1e9862ffa1615efcabe697a0c4e9ef01646f538e) Remove settings preview page ### 📊 Changes **13 files changed** (+73 additions, -694 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -6) 📝 `app.go` (+36 -76) 📝 `frontend/index.html` (+13 -5) 📝 `frontend/src/main.js` (+5 -1) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -2) 📝 `internal/xhotkey/hotkey_linux.go` (+3 -4) 📝 `internal/xhotkey/hotkey_linux_platform.go` (+1 -17) ➖ `internal/xhotkey/hotkey_linux_portal.go` (+0 -549) 📝 `internal/xhotkey/hotkey_linux_test.go` (+8 -28) 📝 `internal/xhotkey/hotkey_linux_types.go` (+1 -1) 📝 `internal/xhotkey/hotkey_nocgo_test.go` (+1 -1) 📝 `scripts/build-linux.sh` (+3 -3) </details> ### 📄 Description ### Motivation - Linux global-hotkey/portal code was fragile and introduced a D-Bus dependency and platform-specific complexity, so the app should rely on the user's desktop custom-shortcut mechanism instead. ### Description - Stop registering an in-app global hotkey on Linux by making the Linux hotkey `Register` return an explanatory error and simplifying `Unregister`, and remove the portal backend implementation and `godbus/dbus` dependency from `go.mod`. - Prevent the app from starting the built-in hotkey listener on Linux and change `SaveSettings` to ignore in-app shortcut recording on Linux while preserving behavior on other OSes (`app.go` changes). - Update the UI and frontend to hide the shortcut recorder on Linux and expose a copyable `Linux System Shortcut` command shown in Settings, and update `README.md` and `scripts/build-linux.sh` messaging to document the new workflow. - Adjust and add tests to assert the Linux hotkey registration is disabled (`internal/xhotkey/hotkey_linux_test.go`) and update related test comments. ### Testing - Ran the updated Linux hotkey unit test `TestHotkeyLinuxUsesDesktopShortcutFallback` in `internal/xhotkey`, which passed and confirmed `Register` returns the expected error. - Ran `go test ./...` across the repository and the test suite completed successfully. ------ [Codex Task](https://chatgpt.com/codex/cloud/tasks/task_e_6a56c7a73170833397150a048ec0af32) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

jahruz67 added the pull-request label 2026-08-08 18:06:18 +00:00

jahruz67 closed this issue

2026-08-08 18:06:18 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jahruz67/wisp-open#7